Please drop Al Viro from the CC (!?) and CC the maintainer of the pldm
library (Jake).
On Sun, 10 Nov 2024 20:28:42 -0800 Lee Trager wrote:
> +/**
> + * fbnic_send_package_data - Send record package data to firmware
> + * @context: PLDM FW update structure
> + * @data: pointer to the package data
> + * @length: length of the package data
> + *
> + * Send a copy of the package data associated with the PLDM record matching
> + * this device to the firmware.
> + *
> + * Return: zero on success
> + * negative error code on failure
> + */
can we drop these kdocs please? In the bast case they just repeat
the function name ("send package data") 3 times, in the worst case they
are misleading. This function sends absolutely nothing to the firmware.
> +static int fbnic_send_package_data(struct pldmfw *context, const u8 *data,
> + u16 length)
> +{
> + struct device *dev = context->dev;
> +
> + /* Temp placeholder required by devlink */
Do you mean that the pldm lib requires this callback to exist?
If yes then make it not require it if it's not necessary?
> + dev_info(dev,
> + "Sending %u bytes of PLDM record package data to firmware\n",
> + length);
Please drop all the dev_*() prints. If something is important enough to
be reported it should be reported via the devlink info channel, to the
user. Not to system logs.
> + return 0;
> +}
--
pw-bot: cr
