Re: [PATCH 2/2] docs: media: Debugging guide for the media subsystem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey Jon,

On 07.11.2024 13:40, Jonathan Corbet wrote:
Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx> writes:

Provide a guide for developers on how to debug code with a focus on the
media subsystem. This document aims to provide a rough overview over the
possibilities and a rational to help choosing the right tool for the
given circumstances.

Signed-off-by: Sebastian Fricke <sebastian.fricke@xxxxxxxxxxxxx>
---
 Documentation/process/debugging/index.rst          |   1 +
 .../debugging/media_specific_debugging_guide.rst   | 178 +++++++++++++++++++++
 2 files changed, 179 insertions(+)

Mostly overall comments here

- much of what's here seems redundant with your other new documents; you
 seem to be going over the same list of tools?  Why not just talk about
 the ones that are unique to the media subsystem?

I choosed the minimum duplication path because of the perspective that I
envisioned of the reader.
The reader reads that there is a debugging guide for the media
subsystem, which to my ears sounds like:
"Everything you need to know to get started debugging in this subsystem,
with recommendations for useful tools"
and not
"Some specific media bits that expect you to have read every other
debugging documentation and judge yourself which of these tools might be
useful for your debugging".

I look at that specifically from a perspective that the general
debugging guides are probably going to be extended in the future with
more general debugging tools which might not be as useful for the media
subsystem.


- Please use the function() convention throughout.

Ack. I assume you also mean the titles as well.


- Back in the ancient past when I was writing V4L2 drivers, one of my
 biggest problems was figuring out why applications weren't getting
 what they expected.  The vivi driver was most useful for finding
 subtle differences...  One would use vivid now, but I suspect the
 utility remains.

Okay I'll look into that.


Thanks,

jon

Regards,

Sebastian Fricke




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux