On Wed, 6 Nov 2024 18:05:55 -0800 Sanman Pradhan wrote: > + FBNIC_HW_STAT("pcie_ob_rd_tlp", pcie.ob_rd_tlp), > + FBNIC_HW_STAT("pcie_ob_rd_dword", pcie.ob_rd_dword), > + FBNIC_HW_STAT("pcie_ob_wr_tlp", pcie.ob_wr_tlp), > + FBNIC_HW_STAT("pcie_ob_wr_dword", pcie.ob_wr_dword), > + FBNIC_HW_STAT("pcie_ob_cpl_tlp", pcie.ob_cpl_tlp), > + FBNIC_HW_STAT("pcie_ob_cpl_dword", pcie.ob_cpl_dword), > + FBNIC_HW_STAT("pcie_ob_rd_no_tag", pcie.ob_rd_no_tag), > + FBNIC_HW_STAT("pcie_ob_rd_no_cpl_cred", pcie.ob_rd_no_cpl_cred), > + FBNIC_HW_STAT("pcie_ob_rd_no_np_cred", pcie.ob_rd_no_np_cred), Having thought about this a bit longer I think Andrew's point is valid. Let's move these to a debugfs file. Sorry for the flip flop.