On Thu, 31 Oct 2024 22:11:18 +0100 Andrew Lunn <andrew@xxxxxxx> wrote: > > + val = tps23881_set_val(ret, chan, 0, BIT(chan % 4), BIT(chan % 4)); > > + val = tps23881_set_val(val, chan, 0, BIT(chan % 4), > > + BIT(chan % 4)); > > + val = tps23881_set_val(ret, chan, 4, BIT(chan % 4), BIT(chan % 4)); > > + val = tps23881_set_val(val, chan, 4, BIT(chan % 4), > > + BIT(chan % 4)); > > + val = tps23881_calc_val(ret, chan, 0, BIT(chan % 4)); > > + val = tps23881_calc_val(ret, chan, 0, BIT(chan % 4)); > > + val = tps23881_calc_val(ret, chan, 0, BIT(chan % 4)); > > + val = tps23881_calc_val(ret, chan, 4, BIT(chan % 4)); > > + val = tps23881_calc_val(ret, chan, 0, BIT(chan % 4)); > > + val = tps23881_calc_val(ret, chan, 4, BIT(chan % 4)); > > It looks like all the callers of this helper pass BIT(chan % 4) as the > last parameter. Maybe move that into the helper as well? There is different cases in the patch 4 of the series. Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
