On Wed, Nov 06, 2024 at 02:22:51PM +0200, Leon Romanovsky wrote: > On Tue, Nov 05, 2024 at 04:26:25PM -0800, Sanman Pradhan wrote: > > Add PCIe hardware statistics support to the fbnic driver. These stats > > provide insight into PCIe transaction performance and error conditions, > > including, read/write and completion TLP counts and DWORD counts and > > debug counters for tag, completion credit and NP credit exhaustion > > > > The stats are exposed via ethtool and can be used to monitor PCIe > > performance and debug PCIe issues. > > And how does PCIe statistics belong to ethtool? > > This PCIe statistics to debug PCIe errors and arguably should be part of > PCI core and not hidden in netdev tool. How would this be done in the PCI core? As far as I can tell, all these registers are device-specific and live in some device BAR. Bjorn
