On Wed, Nov 06, 2024 at 06:18:08AM +0000, Vicentiu Galanopulo wrote: > The LED1202 is a 12-channel low quiescent current LED driver with: > * Supply range from 2.6 V to 5 V > * 20 mA current capability per channel > * 1.8 V compatible I2C control interface > * 8-bit analog dimming individual control > * 12-bit local PWM resolution > * 8 programmable patterns > > If the led node is present in the controller then the channel is > set to active. > > v1: https://lore.kernel.org/lkml/ZnCnnQfwuRueCIQ0@admins-Air/T/ > v2: https://lore.kernel.org/all/ZniNdGgKyUMV-hjq@admins-Air/T/ > v3: https://lore.kernel.org/all/ZniNdGgKyUMV-hjq@admins-Air/T/ This goes after ---. Please run scripts/checkpatch.pl and fix reported warnings. Then please run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. This ws correct in v3 so I do not understand what is happening with this patch. > > Signed-off-by: Vicentiu Galanopulo <vicentiu.galanopulo@xxxxxxxxxxxxxxxxx> > > --- > Changes in v4: > - remove label property, use devm_led_classdev_register_ext instead Where? This is a binding. > - use as base patch the v3 What does it mean? How can you no use v3, but something else? > Changes in v3: > - remove active property > Changes in v2: > - renamed label to remove color from it > - add color property for each node > - add function and function-enumerator property for each node > --- You have also whitespace errors in your patch. Again: Please run scripts/checkpatch.pl and fix reported warnings. Then please run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. > .../devicetree/bindings/leds/st,led1202.yaml | 132 ++++++++++++++++++ > 1 file changed, 132 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/st,led1202.yaml Best regards, Krzysztof
