Hi Conor, On Tue, Nov 5, 2024 at 7:35 PM Conor Dooley <conor@xxxxxxxxxx> wrote: > On Tue, Nov 05, 2024 at 07:45:38AM -0800, Guenter Roeck wrote: > > On 11/5/24 04:19, Rob Herring wrote: > > > On Mon, Nov 4, 2024 at 7:20 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > > > Turns out it is also documented as "isil,isl68137" in trivial-devices.yaml > > > > (together with isil,isl69260). Both are referenced in .dts files. How should > > > > that be handled ? > > > > > > Move those compatibles here. And this file should be renamed to > > > isil,isl68137.yaml or some other actual compatible value. > > > > > > > I guess that is a bit more complicated since Renesas acquired Intersil. > > Is there a common guidance explaining how new compatibles should be defined > > in such situations ? > > > > Anyway, I had the patches queued in linux-next. I dropped them until > > this is sorted out. > > The old ones with existing compatibles should keep their names, the new ones > should probably match whatever is in their datasheet so that people can > have an easier time. Renesas seems to have a document about that: https://www.renesas.com/en/document/gde/intersil-part-code-nomenclature-guide But of course that doesn't help with the vendor prefix... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds