On Thu, 31 Oct 2024 22:54:00 +0100
Andrew Lunn <andrew@xxxxxxx> wrote:
> > +static struct phy_device *
> > +pse_control_find_phy_by_id(struct pse_controller_dev *pcdev, int id)
> > +{
> > + struct pse_control *psec;
> > +
> > + mutex_lock(&pse_list_mutex);
> > + list_for_each_entry(psec, &pcdev->pse_control_head, list) {
> > + if (psec->id == id)
> > + return psec->attached_phydev;
>
> The mutex is still locked. I'm surprised your testing did not
> deadlock, and that none of the automated tools have reported this.
Ouch indeed! As explained in the cover letter, this v2 has not been fully
tested.
But I have built it with smatch and sparse. Weirdly they didn't find it.
Thanks for seeing it.
> ---
> pw-bot: cr
Does RFC patch series pass through the netdev CI build test?
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
