On Wed, Oct 30, 2024 at 05:53:07PM +0100, Kory Maincent wrote:
...
> /**
> * struct pse_control - a PSE control
> @@ -440,18 +441,22 @@ int pse_controller_register(struct pse_controller_dev *pcdev)
>
> mutex_init(&pcdev->lock);
> INIT_LIST_HEAD(&pcdev->pse_control_head);
> + ret = ida_alloc_max(&pse_ida, INT_MAX, GFP_KERNEL);
s/INT_MAX/U32_MAX
...
> struct pse_control_status {
> + u32 pse_id;
> enum ethtool_podl_pse_admin_state podl_admin_state;
...
> struct pse_controller_dev {
> const struct pse_controller_ops *ops;
> @@ -163,6 +166,7 @@ struct pse_controller_dev {
> enum ethtool_pse_types types;
> struct pse_pi *pi;
> bool no_of_pse_pi;
> + int id;
u32 id
It would be better to have one type for all variables.
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
