Re: [PATCH net-next v6 1/1] binder: report txn errors via generic netlink

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 28 Oct 2024 03:19:51 -0700 Li Li wrote:
> +			report.err = BR_ONEWAY_SPAM_SUSPECT;
> +			report.from_pid = proc->pid;
> +			report.from_tid = thread->pid;
> +			report.to_pid = target_proc ? target_proc->pid : 0;
> +			report.to_tid = target_thread ? target_thread->pid : 0;
> +			report.reply = reply;
> +			report.flags = tr->flags;
> +			report.code = tr->code;
> +			report.data_size = tr->data_size;
> +			binder_genl_send_report(context, &report, sizeof(report));

Could you break this struct apart into individual attributes?
Carrying binary structs in netlink has been done historically 
but we moved away from it. It undermines the ability to extend
the output and do automatic error checking.

BTW if you would like to keep using the uapi/linux/android directory
feel free to add this as the first patch of the series:
https://github.com/kuba-moo/linux/commit/73fde49060cd89714029ccee5d37dcc37b8291f6




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux