On Fri, Oct 25, 2024 at 07:46:53PM -0500, Ira Weiny wrote: > The printf tests for struct resource were stubbed out. struct range > printing will leverage the struct resource implementation. > > To prevent regression add some basic sanity tests for struct resource. ... > + struct resource test_resource = { > + .start = 0xc0ffee00, > + .end = 0xc0ffee00, > + .flags = IORESOURCE_MEM, > + }; > + > + test("[mem 0xc0ffee00 flags 0x200]", > + "%pr", &test_resource); > + > + test_resource = (struct resource) { > + .start = 0xc0ffee, > + .end = 0xba5eba11, > + .flags = IORESOURCE_MEM, > + }; > + test("[mem 0x00c0ffee-0xba5eba11 flags 0x200]", > + "%pr", &test_resource); > + > + test_resource = (struct resource) { > + .start = 0xba5eba11, > + .end = 0xc0ffee, > + .flags = IORESOURCE_MEM, > + }; > + test("[mem 0xba5eba11-0x00c0ffee flags 0x200]", > + "%pr", &test_resource); > + > + test_resource = (struct resource) { > + .start = 0xba5eba11, > + .end = 0xba5eca11, > + .flags = IORESOURCE_MEM, > + }; > + > + test("[mem 0xba5eba11-0xba5eca11 flags 0x200]", > + "%pr", &test_resource); > + > + test_resource = (struct resource) { > + .start = 0xba11, > + .end = 0xca10, > + .flags = IORESOURCE_IO | > + IORESOURCE_DISABLED | > + IORESOURCE_UNSET, > + }; I know that I have given my tag, but I just realized that you may use DEFINE_RES_*() macros here. -- With Best Regards, Andy Shevchenko