On 10/24/24 2:10 AM, Simon Horman wrote:
On Mon, Oct 21, 2024 at 06:42:24PM -0700, Lee Trager wrote:
fbnic supports updating firmware using a PLDM image signed and distributed
by Meta. PLDM images are written into stored flashed. Flashing does not
interrupt operation.
On host reboot the newly flashed UEFI driver will be used. To run new
control or cmrt firmware the NIC must be power cycled.
Signed-off-by: Lee Trager <lee@xxxxxxxxx>
...
diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_devlink.c b/drivers/net/ethernet/meta/fbnic/fbnic_devlink.c
...
@@ -109,8 +110,274 @@ static int fbnic_devlink_info_get(struct devlink *devlink,
return 0;
}
+/**
+ * fbnic_send_package_data - Send record package data to firmware
+ * @context: PLDM FW update structure
+ * @data: pointer to the package data
+ * @length: length of the package data
+ *
+ * Send a copy of the package data associated with the PLDM record matching
+ * this device to the firmware.
+ *
+ * Return: zero on success
+ * negative error code on failure
+ */
+static int fbnic_send_package_data(struct pldmfw *context, const u8 *data,
+ u16 length)
+{
+ struct device *dev = context->dev;
+
+ /* Temp placeholder required by devlink */
+ dev_info(dev,
+ "Sending %u bytes of PLDM record package data to firmware\n",
+ length);
Could you clarify what is meant by "Temp placeholder" here and in
fbnic_send_component_table(). And what plans there might be for
a non-temporary solution.
Temp placeholder may not have been the best wording here. pldmfw
requires all ops to be defined as they are always called[1] when
updating. fbnic has an info message here so its doing something but we
have no current plans to expand on fbnic_send_package_data nor
fbnic_finalize_update.
[1]
https://elixir.bootlin.com/linux/v6.12-rc4/source/lib/pldmfw/pldmfw.c#L723
+
+ return 0;
+}
+
+/**
+ * fbnic_send_component_table - Send PLDM component table to the firmware
+ * @context: PLDM FW update structure
+ * @component: The component to send
+ * @transfer_flag: Flag indication location in component tables
+ *
+ * Read relevant data from component table and forward it to the firmware.
+ * Check response to verify if the firmware indicates that it wishes to
+ * proceed with the update.
+ *
+ * Return: zero on success
+ * negative error code on failure
+ */
+static int fbnic_send_component_table(struct pldmfw *context,
+ struct pldmfw_component *component,
+ u8 transfer_flag)
+{
+ struct device *dev = context->dev;
+ u16 id = component->identifier;
+ u8 test_string[80];
+
+ switch (id) {
+ case QSPI_SECTION_CMRT:
+ case QSPI_SECTION_CONTROL_FW:
+ case QSPI_SECTION_OPTION_ROM:
+ break;
+ default:
+ dev_err(dev, "Unknown component ID %u\n", id);
+ return -EINVAL;
+ }
+
+ dev_dbg(dev, "Sending PLDM component table to firmware\n");
+
+ /* Temp placeholder */
+ strscpy(test_string, component->version_string,
+ min_t(u8, component->version_len, 79));
+ dev_info(dev, "PLDMFW: Component ID: %u version %s\n",
+ id, test_string);
+
+ return 0;
+}
...
