Re: [PATCH v4 6/6] Add Propeller configuration for kernel build.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Masahiro Yamada" <masahiroy@xxxxxxxxxx>, "Rong Xu" <xur@xxxxxxxxxx>
Subject: Re: [PATCH v4 6/6] Add Propeller configuration for kernel build.
From: "Arnd Bergmann" <arnd@xxxxxxxx>
Date: Wed, 23 Oct 2024 07:25:03 +0000
Cc: "Alice Ryhl" <aliceryhl@xxxxxxxxxx>, "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>, "Bill Wendling" <morbo@xxxxxxxxxx>, "Borislav Petkov" <bp@xxxxxxxxx>, "Breno Leitao" <leitao@xxxxxxxxxx>, "Brian Gerst" <brgerst@xxxxxxxxx>, "Dave Hansen" <dave.hansen@xxxxxxxxxxxxxxx>, "David Li" <davidxl@xxxxxxxxxx>, "Han Shen" <shenhan@xxxxxxxxxx>, "Heiko Carstens" <hca@xxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, "Ingo Molnar" <mingo@xxxxxxxxxx>, "Jann Horn" <jannh@xxxxxxxxxx>, "Jonathan Corbet" <corbet@xxxxxxx>, "Josh Poimboeuf" <jpoimboe@xxxxxxxxxx>, "Juergen Gross" <jgross@xxxxxxxx>, "Justin Stitt" <justinstitt@xxxxxxxxxx>, "Kees Cook" <kees@xxxxxxxxxx>, "Mike Rapoport" <rppt@xxxxxxxxxx>, "Nathan Chancellor" <nathan@xxxxxxxxxx>, "Nick Desaulniers" <ndesaulniers@xxxxxxxxxx>, "Nicolas Schier" <nicolas@xxxxxxxxx>, "Paul E. McKenney" <paulmck@xxxxxxxxxx>, "Peter Zijlstra" <peterz@xxxxxxxxxxxxx>, "Sami Tolvanen" <samitolvanen@xxxxxxxxxx>, "Thomas Gleixner" <tglx@xxxxxxxxxxxxx>, "Wei Yang" <richard.weiyang@xxxxxxxxx>, workflows@xxxxxxxxxxxxxxx, "Miguel Ojeda" <miguel.ojeda.sandonis@xxxxxxxxx>, "Maksim Panchenko" <max4bolt@xxxxxxxxx>, x86@xxxxxxxxxx, Linux-Arch <linux-arch@xxxxxxxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, linux-kbuild@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, llvm@xxxxxxxxxxxxxxx, "Sriraman Tallam" <tmsriram@xxxxxxxxxx>, "Krzysztof Pszeniczny" <kpszeniczny@xxxxxxxxxx>, "Stephane Eranian" <eranian@xxxxxxxxxx>
Feedback-id: i56a14606:Fastmail
In-reply-to: <CAK7LNAQr_EusZyy-dPcV=5o9UckStaUfXLSCQh7APbYh15NC3w@mail.gmail.com>
References: <20241014213342.1480681-1-xur@google.com> <20241014213342.1480681-7-xur@google.com> <CAK7LNARfm7HBx-wLCak1w0sfH7LML1ErWO=2sLj4ovR38RsnTA@mail.gmail.com> <CAF1bQ=Qi9hyKbc5H3N36W=MukT3321rZMCas0ndpRf0YszAfOA@mail.gmail.com> <CAK7LNAQr_EusZyy-dPcV=5o9UckStaUfXLSCQh7APbYh15NC3w@mail.gmail.com>

On Wed, Oct 23, 2024, at 07:06, Masahiro Yamada wrote:
> On Tue, Oct 22, 2024 at 9:00 AM Rong Xu <xur@xxxxxxxxxx> wrote:
>
>> > > +===========
>> > > +
>> > > +Configure the kernel with::
>> > > +
>> > > +   CONFIG_AUTOFDO_CLANG=y
>> >
>> >
>> > This is automatically met due to "depends on AUTOFDO_CLANG".
>>
>> Agreed. But we will remove the dependency from PROPELlER_CLANG to AUTOFDO_CLANG.
>> So we will keep the part.
>
>
> You can replace "depends on AUTOFDO_CLANG" with
> "imply AUTOFDO_CLANG" if it is sensible.
>
> Up to you.

I don't think we should ever encourage the use of 'imply'
because it is almost always used incorrectly.

       Arnd

Follow-Ups:
- Re: [PATCH v4 6/6] Add Propeller configuration for kernel build.
  - From: Masahiro Yamada

References:
- [PATCH v4 0/6] Add AutoFDO and Propeller support for Clang build
  - From: Rong Xu
- [PATCH v4 6/6] Add Propeller configuration for kernel build.
  - From: Rong Xu
- Re: [PATCH v4 6/6] Add Propeller configuration for kernel build.
  - From: Masahiro Yamada
- Re: [PATCH v4 6/6] Add Propeller configuration for kernel build.
  - From: Rong Xu
- Re: [PATCH v4 6/6] Add Propeller configuration for kernel build.
  - From: Masahiro Yamada

Prev by Date: Re: [PATCH v4 6/6] Add Propeller configuration for kernel build.
Next by Date: Re: [PATCH v4 6/6] Add Propeller configuration for kernel build.
Previous by thread: Re: [PATCH v4 6/6] Add Propeller configuration for kernel build.
Next by thread: Re: [PATCH v4 6/6] Add Propeller configuration for kernel build.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]