On Fri, Oct 18, 2024 at 12:46:14PM -0700, Doug Anderson wrote: > Hi, > > On Fri, Oct 18, 2024 at 10:55 AM Nir Lichtman <nir@xxxxxxxxxxxx> wrote: > > > > @@ -201,7 +201,7 @@ Using loadable module or built-in > > Configure kgdboc at runtime with sysfs > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > > > -At run time you can enable or disable kgdboc by echoing a parameters > > +At run time you can enable or disable kgdboc by writing parameters > > into sysfs. Here are two examples: > > In response to v1, Matthew wanted you to change "the sysfs" into > "sysfs". In the above it's no longer "the sysfs" but it's not part of > your patch (no "-" of the old line with the "the" and "+" of the new > line without the "the". Huh? This causes the patch to fail to apply. > > Other than that, this all looks fine to me. > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> Thanks, sorry about that mistake, will send a v3 with a fix shortly.