Jonathan Cameron wrote: > On Mon, 07 Oct 2024 18:16:21 -0500 > Ira Weiny <ira.weiny@xxxxxxxxx> wrote: > > > create_pmem_region_store() and create_ram_region_store() are identical > > with the exception of the region mode. With the addition of DC region > > mode this would end up being 3 copies of the same code. > > > > Refactor create_pmem_region_store() and create_ram_region_store() to use > > a single common function to be used in subsequent DC code. > > > > Suggested-by: Fan Ni <fan.ni@xxxxxxxxxxx> > > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx> > Nice. > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Is it worth dragging out cleanup like this to the start of the series so > Dave can queue it up as 'good to have whatever' and reduce this set > a bit? The problem was that this patch depended on the region mode change... But that was an easy change. I've moved it forward. Ira
