On Sat, Nov 23, 2013 at 11:50:29AM +0000, Jonathan Cameron wrote: > On 10/26/13 00:09, Sebastian Reichel wrote: > > Hi Grant, > > > > On Fri, Oct 25, 2013 at 08:10:28PM +0100, Grant Likely wrote: > >>> + - cover-comp-gain : integer used as multiplier for gain + compensation (default = 1) > >> > >> Should be taos,cover-comp-gain > > > > Has been updated to "amstaos,cover-comp-gain" in the latest patches, see https://lkml.org/lkml/2013/10/25/59 > > > >> Otherwise looks fine to me. > > > > Is this an acked-by? > It's good enough for me to take the patch :) > > > >>> + else if (np) + of_property_read_u32_index(np, "cover-comp-gain", 0, + &chip->cover_comp_gain); > >> > >> of_property_read_u32() should be sufficient. You don't need the _index variant. > > > > ah, I missed the function when skipping over linux/of.h. I will sent another update. > > Did you do this? Latest I seem to have is V3 and that doesn't have > this change. Sorry, I forgot, that I still had work to do for this patch :( > I've made the obvious change to your V3 and applied it. Thanks for taking care of it. -- Sebastian
Attachment:
signature.asc
Description: Digital signature
