Hi, On 16-Oct-24 11:36 AM, Uwe Kleine-König wrote: > Hello, > > On Thu, Oct 10, 2024 at 02:36:57PM -0500, Mario Limonciello wrote: >> +static struct platform_driver amd_hfi_driver = { >> + .driver = { >> + .name = AMD_HFI_DRIVER, >> + .owner = THIS_MODULE, >> + .acpi_match_table = ACPI_PTR(amd_hfi_platform_match), >> + }, >> + .probe = amd_hfi_probe, >> + .remove_new = amd_hfi_remove, >> +}; > > After commit 0edb555a65d1 ("platform: Make platform_driver::remove() > return void") .remove() is (again) the right callback to implement for > platform drivers. Please just drop "_new". Note there is a "[v3,05/14] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver" patch superseding this one now; and that one has the same issue. Regards, Hans