Fan Ni wrote: > On Mon, Oct 07, 2024 at 06:16:18PM -0500, Ira Weiny wrote: > > Additional DCD region (partition) information is contained in the DSMAS > > CDAT tables, including performance, read only, and shareable attributes. > > > > Match DCD partitions with DSMAS tables and store the meta data. > > > > To: Robert Moore <robert.moore@xxxxxxxxx> > > To: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > To: Len Brown <lenb@xxxxxxxxxx> > > Cc: linux-acpi@xxxxxxxxxxxxxxx > > Cc: acpica-devel@xxxxxxxxxxxxxxx > > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx> > > > > One minor comment inline. > > > --- > > Changes: > > [iweiny: new patch] > > [iweiny: Gather shareable/read-only flags for later use] > > --- > > drivers/cxl/core/cdat.c | 38 ++++++++++++++++++++++++++++++++++++++ > > drivers/cxl/core/mbox.c | 2 ++ > > drivers/cxl/cxlmem.h | 3 +++ > > include/acpi/actbl1.h | 2 ++ > > 4 files changed, 45 insertions(+) > > > > diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c > > index bd50bb655741..9b2f717a16e5 100644 > > --- a/drivers/cxl/core/cdat.c > > +++ b/drivers/cxl/core/cdat.c > > @@ -17,6 +17,8 @@ struct dsmas_entry { > > struct access_coordinate cdat_coord[ACCESS_COORDINATE_MAX]; > > int entries; > > int qos_class; > > + bool shareable; > > + bool read_only; > > }; > > > > static u32 cdat_normalize(u16 entry, u64 base, u8 type) > > @@ -74,6 +76,8 @@ static int cdat_dsmas_handler(union acpi_subtable_headers *header, void *arg, > > return -ENOMEM; > > > > dent->handle = dsmas->dsmad_handle; > > + dent->shareable = dsmas->flags & ACPI_CDAT_DSMAS_SHAREABLE; > > + dent->read_only = dsmas->flags & ACPI_CDAT_DSMAS_READ_ONLY; > > dent->dpa_range.start = le64_to_cpu((__force __le64)dsmas->dpa_base_address); > > dent->dpa_range.end = le64_to_cpu((__force __le64)dsmas->dpa_base_address) + > > le64_to_cpu((__force __le64)dsmas->dpa_length) - 1; > > @@ -255,6 +259,38 @@ static void update_perf_entry(struct device *dev, struct dsmas_entry *dent, > > dent->coord[ACCESS_COORDINATE_CPU].write_latency); > > } > > > > + > Unwanted blank line. Fixed. Thanks. Ira