Hi Mark, Sorry for the delay, but I was somehow removed from the recipients in your reply. As I am not subscribed to rtc-linux, can you keep me in Cc: next time? > On Mon, Nov 18, 2013 at 09:51:27PM +0100, Arnaud Ebalard wrote: > > > +/* Block read. Returns 0 on success, or a negative errno. */ > > +static int isl12057_i2c_read_regs(struct i2c_client *client, u8 reg, u8 buf[], > > + unsigned len) > > This looks like the device would work well with regmap (8 bit register, > 8 bit data). This would save a bit of code here both for the I/O > functions and also for some of the debugging functionality you have > below like the proc file. Well, I am not familiar with regmap but if you can point me some simple rtc driver in existing ones which uses regmap, I will take a look and come with a regmap-based v3. > > + dev_info(dev, "chip found, driver version " DRV_VERSION "\n"); > > This sort of print is generally frowned upon - it's not adding anything > to the message already displayed by the RTC core on registration. It's > probably best to remove the driver version too, the kernel is already > versioned. ok, will do. Cheers, a+ -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
