On Wed, Oct 09, 2024 at 05:45:10PM +0300, Andy Shevchenko wrote: > On Tue, Oct 08, 2024 at 06:10:32PM +0200, David Sterba wrote: > > On Mon, Oct 07, 2024 at 06:16:10PM -0500, Ira Weiny wrote: ... > > > +static inline bool range_overlaps(struct range *r1, struct range *r2) > > > > I've noticed only now, you can constify the arguments, but this applise > > to other range_* functions so that can be done later in one go. > > Frankly you may add the same to each new API being added to the file and > the "one go" will never happen. So, I support your first part with > constifying, but I think it would be rather done now to start that "one > go" to happen. Alternatively there is should be the patch _in this series_ to make it happen before extending an API. I leave the choice to Ira. -- With Best Regards, Andy Shevchenko
