Re: [PATCH net-next v3 4/7] bnxt_en: add support for tcp-data-split-thresh ethtool command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 9, 2024 at 3:35 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Thu,  3 Oct 2024 16:06:17 +0000 Taehee Yoo wrote:
> > +#define BNXT_HDS_THRESHOLD_MAX       256
> > +     u16                     hds_threshold;
>
> From the cover letter it sounded like the max is 1023.
> Did I misread that ?

Based on my test, the maximum value seems to be 1023.
But I'm not sure that all NICs, that use bnxt_en driver support 1023 value.
(At least all NICs I have support 1023).
I decided 256 as the maximum value, that was default value so all
NICs can use it safely. If Broadcom Engineer confirms 1023 is right
 for all NICs, I would like to change it.





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux