Re: powermac: Call of_node_put(bk_node) only once in pmac_has_backlight_type()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> First of all, the change is wrong.  We can't dereference "prop" after calling
> of_node_put().
…
> The of_get_property() function doesn't do a get as in get/put, it just finds
> the property and returns it.  It doesn't bump the reference count.  It's a
> confusing name in that way.  The The of_node_put() pairs with
> of_find_node_by_name().
Thanks for your information.

* Do you see opportunities for improving the software documentation accordingly?

* How much can source code analysis tools influence development efforts?


Regards,
Markus





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux