Hi Charlie, Charlie Jenkins <charlie@xxxxxxxxxxxx> 於 2024年9月12日 週四 下午1:57寫道： > > The VXRM vector csr for xtheadvector has an encoding of 0xa and VXSAT > has an encoding of 0x9. > > Co-developed-by: Heiko Stuebner <heiko@xxxxxxxxx> > Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx> > Signed-off-by: Charlie Jenkins <charlie@xxxxxxxxxxxx> > --- > arch/riscv/include/asm/csr.h | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/arch/riscv/include/asm/csr.h b/arch/riscv/include/asm/csr.h > index 3eeb07d73065..c0a60c4ed911 100644 > --- a/arch/riscv/include/asm/csr.h > +++ b/arch/riscv/include/asm/csr.h > @@ -300,9 +300,14 @@ > #define CSR_STIMECMP 0x14D > #define CSR_STIMECMPH 0x15D > > -#define VCSR_VXRM_MASK 3 > -#define VCSR_VXRM_SHIFT 1 > -#define VCSR_VXSAT_MASK 1 > +/* xtheadvector symbolic CSR names */ > +#define CSR_VXSAT 0x9 > +#define CSR_VXRM 0xa > + > +/* xtheadvector CSR masks */ > +#define CSR_VXRM_MASK 3 > +#define CSR_VXRM_SHIFT 1 > +#define CSR_VXSAT_MASK 1 nit: use VCSR_VX* instead of CSR_VX*, if you need to send the next revision. I believe these masks are for CSR_VCSR but not CSR_VX*. If you think CSR_VX* is a better naming then the previous patch should introduce it as CSR_VX* but not VCSR_VX*. > > /* Supervisor-Level Window to Indirectly Accessed Registers (AIA) */ > #define CSR_SISELECT 0x150 > > -- > 2.45.0 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-riscv Thanks, Andy
