Hi Armin, On 5-Oct-24 11:38 PM, Armin Wolf wrote: > The WMI driver core now passes the WMI event data to legacy notify > handlers, so WMI devices sharing notification IDs are now being > handled properly. > > Fixes: e04e2b760ddb ("platform/x86: wmi: Pass event data directly to legacy notify handlers") > Signed-off-by: Armin Wolf <W_Armin@xxxxxx> Thank you for your patch/series, I've applied this patch (series) to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Since patch 2/2 makes non pure bugfix functional changes I expect Ilpo to pick that one up for pdx86/for-next. Regards, Hans > --- > Documentation/driver-api/wmi.rst | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/Documentation/driver-api/wmi.rst b/Documentation/driver-api/wmi.rst > index 6ca58c8249e5..4e8dbdb1fc67 100644 > --- a/Documentation/driver-api/wmi.rst > +++ b/Documentation/driver-api/wmi.rst > @@ -7,12 +7,11 @@ WMI Driver API > The WMI driver core supports a more modern bus-based interface for interacting > with WMI devices, and an older GUID-based interface. The latter interface is > considered to be deprecated, so new WMI drivers should generally avoid it since > -it has some issues with multiple WMI devices and events sharing the same GUIDs > -and/or notification IDs. The modern bus-based interface instead maps each > -WMI device to a :c:type:`struct wmi_device <wmi_device>`, so it supports > -WMI devices sharing GUIDs and/or notification IDs. Drivers can then register > -a :c:type:`struct wmi_driver <wmi_driver>`, which will be bound to compatible > -WMI devices by the driver core. > +it has some issues with multiple WMI devices sharing the same GUID. > +The modern bus-based interface instead maps each WMI device to a > +:c:type:`struct wmi_device <wmi_device>`, so it supports WMI devices sharing the > +same GUID. Drivers can then register a :c:type:`struct wmi_driver <wmi_driver>` > +which will be bound to compatible WMI devices by the driver core. > > .. kernel-doc:: include/linux/wmi.h > :internal: > -- > 2.39.5 >