On Fri, Oct 4, 2024 at 1:57 AM Brett Creeley <bcreeley@xxxxxxx> wrote: > Hi Brett, Thanks a lot for the review! > On 10/3/2024 9:06 AM, Taehee Yoo wrote: > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > > > > The bnxt_en driver supports rx-copybreak, but it couldn't be set by > > userspace. Only the default value(256) has worked. > > This patch makes the bnxt_en driver support following command. > > `ethtool --set-tunable <devname> rx-copybreak <value> ` and > > `ethtool --get-tunable <devname> rx-copybreak`. > > > > Signed-off-by: Taehee Yoo <ap420073@xxxxxxxxx> > > --- > > > > v3: > > - Update copybreak value before closing nic. > > Nit, but maybe this should say: > > Update copybreak value after closing nic and before opening nic when the > device is running. > > Definitely not worth a respin, but if you end up having to do a v4. > Thank you so much for catching this. I will fix it if I send a v4 patch. > > > > v2: > > - Define max/vim rx_copybreak value. > > > > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 24 +++++---- > > drivers/net/ethernet/broadcom/bnxt/bnxt.h | 6 ++- > > .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 49 ++++++++++++++++++- > > 3 files changed, 68 insertions(+), 11 deletions(-) > > Other than the tiny nit, LGTM. > > Reviewed-by: Brett Creeley <brett.creeley@xxxxxxx> > > <snip> Thanks a lot! Taehee Yoo
