Re: [PATCH v13 16/40] KVM: arm64: Manage GCS access and registers for guests

[Marc Zyngier <maz@xxxxxxxxxx>]

On Tue, 01 Oct 2024 23:58:55 +0100,
Mark Brown <broonie@xxxxxxxxxx> wrote:

> @@ -4714,6 +4735,10 @@ void kvm_calculate_traps(struct kvm_vcpu *vcpu)
>  		kvm->arch.fgu[HFGxTR_GROUP] |= (HFGxTR_EL2_nPOR_EL1 |
>  						HFGxTR_EL2_nPOR_EL0);
>  
> +	if (!kvm_has_gcs(kvm))
> +		kvm->arch.fgu[HFGxTR_GROUP] |= (HFGxTR_EL2_nGCS_EL0 |
> +						HFGxTR_EL2_nGCS_EL1);
> +

Why are you still allowing the GCS instructions when GCS isn't
enabled?

	M.

-- 
Without deviation from the norm, progress is not possible.