On Wed, Sep 25, 2024 at 04:25:32PM GMT, Nam Cao wrote: > The macro that is really defined is RISCV_HWPROBE_KEY_MIMPID, not > RISCV_HWPROBE_KEY_MIMPLID (difference is the 'L'). > > Also, the riscv privileged specification names the register "mimpid", not > "mimplid". > > Correct these typos. > > Signed-off-by: Nam Cao <namcao@xxxxxxxxxxxxx> > --- > ask me how I found out.. Hopefully due to someone using the document as a reference when attempting to use hwprobe. > > Documentation/arch/riscv/hwprobe.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/arch/riscv/hwprobe.rst b/Documentation/arch/riscv/hwprobe.rst > index 85b709257918..fb0affa61eb9 100644 > --- a/Documentation/arch/riscv/hwprobe.rst > +++ b/Documentation/arch/riscv/hwprobe.rst > @@ -51,7 +51,7 @@ The following keys are defined: > * :c:macro:`RISCV_HWPROBE_KEY_MARCHID`: Contains the value of ``marchid``, as > defined by the RISC-V privileged architecture specification. > > -* :c:macro:`RISCV_HWPROBE_KEY_MIMPLID`: Contains the value of ``mimplid``, as > +* :c:macro:`RISCV_HWPROBE_KEY_MIMPID`: Contains the value of ``mimpid``, as > defined by the RISC-V privileged architecture specification. > > * :c:macro:`RISCV_HWPROBE_KEY_BASE_BEHAVIOR`: A bitmask containing the base > -- > 2.39.2 > Reviewed-by: Andrew Jones <ajones@xxxxxxxxxxxxxxxx> Thanks, drew