Hi Reinette, On 9/19/24 11:55, Reinette Chatre wrote: > Hi Babu, > > On 9/4/24 3:21 PM, Babu Moger wrote: >> The event configuration is domain specific and initialized during domain >> initialization. The values are stored in struct rdt_hw_mon_domain. >> >> It is not required to read the configuration register every time user asks >> for it. Use the value stored in struct rdt_hw_mon_domain instead. >> >> Introduce resctrl_arch_event_config_get() and >> resctrl_arch_event_config_set() to get/set architecture domain specific >> mbm_total_cfg/mbm_local_cfg values. >> >> Signed-off-by: Babu Moger <babu.moger@xxxxxxx> >> --- > > This change looks fine, but could the function names be more specific? For example, > resctrl_arch_mon_event_config_get()/resctrl_arch_mon_event_config_set()? Sure. will do. -- Thanks Babu Moger
