Re: [PATCH] PCI: Fixed spelling in Documentation/PCI/pci.rst

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 06, 2024 at 12:53:18PM GMT, Jonathan Corbet wrote:
> Abdul Rahim <abdul.rahim@xxxxxxxxxxx> writes:
> 
> > On Fri, Sep 06, 2024 at 11:41:52AM GMT, Bjorn Helgaas wrote:
> >> On Fri, Sep 06, 2024 at 06:15:18PM +0530, Abdul Rahim wrote:
> >> > Fixed spelling and edited for clarity.
> >> > 
> >> > Signed-off-by: Abdul Rahim <abdul.rahim@xxxxxxxxxxx>
> >> > ---
> >> >  Documentation/PCI/pci.rst | 2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> > 
> >> > diff --git a/Documentation/PCI/pci.rst b/Documentation/PCI/pci.rst
> >> > index dd7b1c0c21da..344c2c2d94f9 100644
> >> > --- a/Documentation/PCI/pci.rst
> >> > +++ b/Documentation/PCI/pci.rst
> >> > @@ -52,7 +52,7 @@ driver generally needs to perform the following initialization:
> >> >    - Enable DMA/processing engines
> >> >  
> >> >  When done using the device, and perhaps the module needs to be unloaded,
> >> > -the driver needs to take the follow steps:
> >> > +the driver needs to perform the following steps:
> >> 
> >> I don't see a spelling fix here, and personally I wouldn't bother with
> >> changing "take" to "perform" unless we have other more significant
> >> changes to make at the same time.
> >
> > - "follow" has been corrected to "following", which is more appriopriate
> > in this context.
> > - I know its trivial, but can disturb the readers flow
> > - do you want me to change the message to "Edited for clarity"
> 
> The problem is not s/follow/following/, it is the other, unrelated
> change you made that does not improve the text.  There are reasons why
> we ask people not to mix multiple changes.  If you submit just the
> "following" fix, it will surely be applied.
> 
> Thanks,
> 
> jon

Understood, will take care next time. I will resend this patch with:
"follow" -> "following", with commit message "Fixed spelling"




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux