On Fri Sep 6, 2024 at 2:22 PM EEST, Roberto Sassu wrote: > On Fri, 2024-09-06 at 12:41 +0300, Jarkko Sakkinen wrote: > > On Thu Sep 5, 2024 at 6:25 PM EEST, Roberto Sassu wrote: > > > From: Roberto Sassu <roberto.sassu@xxxxxxxxxx> > > > > > > Introduce a new hook to check the integrity of digest lists. > > > > "Introduce DIGEST_LIST_CHECK, a new hook..." > > > > > > > > The new hook is invoked during a kernel read with file type > > > > "with the file type" > > > > > > > READING_DIGEST LIST, which is done by the Integrity Digest Cache when it is > > > populating a digest cache with a digest list. > > > > The patch creates a new struct imap_rule_entry instance when it parses > > the corresponding rule, which means that there are couple slices of > > information missing here: > > > > 1. The commit message does not tell what the code change effectively > > is. I scavenged this information from [1]. > > Sorry, to me it seems a bit redundant to state what a IMA hook is. The > new hook will be handled by IMA like the other existing hooks. I think with documentation (scoping also to commit messages) it is in general a good strategy to put it less rather than more. No documentation is better than polluted documentation ;-) Just remarking what might not be obvious with someone who might not be obvious, unless being a pro-active contributor. BR, Jarkko
