Hi Marek, On 9/3/24 11:32 PM, Marek Maślanka wrote: > Hello Hans, > Do I need to send the fixed patch v7 in response to the https://lore.kernel.org/lkml/e438d8c4-3c10-4674-916b-dd645d19f210@xxxxxxxxxx/ <https://lore.kernel.org/lkml/e438d8c4-3c10-4674-916b-dd645d19f210@xxxxxxxxxx/> to continue the thread? Since Daniel has already merged the patches the fix should be a new separate patch which only replaces the '/**' with '/*' on top of the: timers/drivers/next branch of http://git.linaro.org/people/daniel.lezcano/linux.git: http://git.linaro.org/people/daniel.lezcano/linux.git/log/?h=timers/drivers/next Regards, Hans > On Tue, Sep 3, 2024 at 10:31 AM Hans de Goede <hdegoede@xxxxxxxxxx <mailto:hdegoede@xxxxxxxxxx>> wrote: > > Hi, > > On 9/3/24 8:10 AM, kernel test robot wrote: > > tree: http://git.linaro.org/people/daniel.lezcano/linux <http://git.linaro.org/people/daniel.lezcano/linux> timers/drivers/next > > head: 8f8b0349aa312eb7e67e623ed1f296a04126fe7f > > commit: 2d167560d43c809c66e6389b6cc651b77fcbf951 [4/9] platform/x86:intel/pmc: Enable the ACPI PM Timer to be turned off when suspended > > config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240903/202409031410.a9beukFc-lkp@xxxxxxxxx/config <https://download.01.org/0day-ci/archive/20240903/202409031410.a9beukFc-lkp@xxxxxxxxx/config>) > > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240903/202409031410.a9beukFc-lkp@xxxxxxxxx/reproduce <https://download.01.org/0day-ci/archive/20240903/202409031410.a9beukFc-lkp@xxxxxxxxx/reproduce>) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot <lkp@xxxxxxxxx <mailto:lkp@xxxxxxxxx>> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202409031410.a9beukFc-lkp@xxxxxxxxx/ <https://lore.kernel.org/oe-kbuild-all/202409031410.a9beukFc-lkp@xxxxxxxxx/> > > > > All warnings (new ones prefixed by >>): > > > >>> drivers/platform/x86/intel/pmc/core.c:1213: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > > * Enable or disable ACPI PM Timer > > > > > > vim +1213 drivers/platform/x86/intel/pmc/core.c > > > > 1211 > > 1212 /** > >> 1213 * Enable or disable ACPI PM Timer > > 1214 * > > 1215 * This function is intended to be a callback for ACPI PM suspend/resume event. > > 1216 * The ACPI PM Timer is enabled on resume only if it was enabled during suspend. > > 1217 */ > > Ok, so to fix this we just need to change the /** to /* . > > Marek, can you please submit a patch for this to Daniel? > > Since the commit introducing this problem is in Daniel's > linux/timers/drivers/next tree, the fix will need to be merged > there too. > > Regards, > > Hans > >
