Re: [PATCH net v2] docs: netdev: document guidance on cleanup.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 30, 2024 at 10:14:42AM -0700, Jakub Kicinski wrote:
> Document what was discussed multiple times on list and various
> virtual / in-person conversations. guard() being okay in functions
> <= 20 LoC is a bit of my own invention. If the function is trivial
> it should be fine, but feel free to disagree :)
> 
> We'll obviously revisit this guidance as time passes and we and other
> subsystems get more experience.
> 
> Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>
> Reviewed-by: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> ---
> CC: horms@xxxxxxxxxx
> CC: corbet@xxxxxxx
> CC: linux-doc@xxxxxxxxxxxxxxx
> 
> v2:
>  - add sentence about revisiting later to commit msg
>  - fix spelling
> v1: https://lore.kernel.org/20240829152025.3203577-1-kuba@xxxxxxxxxx

Thanks. I think this patch has enough tags, so I won't add another.
But, FTR, this version looks good to me.

...




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux