On Thu, Aug 29, 2024 at 06:01:16AM +0000, Mina Almasry wrote: ... > diff --git a/net/core/netdev-genl-gen.c b/net/core/netdev-genl-gen.c > index 6b7fe6035067..8b87801e8d1c 100644 > --- a/net/core/netdev-genl-gen.c > +++ b/net/core/netdev-genl-gen.c > @@ -8,6 +8,7 @@ > > #include "netdev-genl-gen.h" > > +#include <linux/list.h> > #include <uapi/linux/netdev.h> Hi Mina, Strangely, when tools/net/ynl/ynl-regen.sh -f runs, it places the includes in the opposite order. I raise this as it may lead to churn later. ... > diff --git a/net/core/netdev-genl-gen.h b/net/core/netdev-genl-gen.h > index 67c34005750c..01ef29ace149 100644 > --- a/net/core/netdev-genl-gen.h > +++ b/net/core/netdev-genl-gen.h > @@ -9,6 +9,7 @@ > #include <net/netlink.h> > #include <net/genetlink.h> > > +#include <linux/list.h> > #include <uapi/linux/netdev.h> Ditto. ...