On Thu, Aug 01, 2024 at 03:56:37PM -0500, Pavan Kumar Paluri wrote:
> +#include <linux/memblock.h>
What's the idea of adding some random include here?
Does this file use memblock?
I don't think so.
You need to resolve include visibility by including the headers where you need
them:
diff --git a/arch/x86/include/asm/sev-common.h b/arch/x86/include/asm/sev-common.h
index dd302fe49f04..d3e7f97e2a4a 100644
--- a/arch/x86/include/asm/sev-common.h
+++ b/arch/x86/include/asm/sev-common.h
@@ -8,6 +8,9 @@
#ifndef __ASM_X86_SEV_COMMON_H
#define __ASM_X86_SEV_COMMON_H
+#include <asm/cache.h>
+#include <asm/pgtable_types.h>
+
#define GHCB_MSR_INFO_POS 0
#define GHCB_DATA_LOW 12
#define GHCB_MSR_INFO_MASK (BIT_ULL(GHCB_DATA_LOW) - 1)
diff --git a/arch/x86/virt/svm/cmdline.c b/arch/x86/virt/svm/cmdline.c
index 507549a9c793..f0a532108f49 100644
--- a/arch/x86/virt/svm/cmdline.c
+++ b/arch/x86/virt/svm/cmdline.c
@@ -5,11 +5,8 @@
* Copyright (C) 2023 - 2024 Advanced Micro Devices, Inc.
*
* Author: Michael Roth <michael.roth@xxxxxxx>
- *
*/
-#include <linux/memblock.h>
-
#include <asm/sev.h>
struct sev_config sev_cfg;
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
