Re: [PATCH 0/2] hexdump: Allow skipping identical lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 27, 2024 at 11:01:47AM +0200, Miquel Raynal wrote:
> andriy.shevchenko@xxxxxxxxxxxxxxx wrote on Mon, 26 Aug 2024 20:32:20
> +0300:
> > On Mon, Aug 26, 2024 at 06:24:14PM +0200, Miquel Raynal wrote:

...

> > Also here is the formal NAK till the series gains the test cases.
> 
> What test cases are you talking about?

Anything meaningful you come up with to show that the printed data is
what it's expected. The module has a complimentary test case,
lib/test_hexdump.c. Without changes in that file, there is no go
to what ever golden ideas you have.

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux