Dave Jiang wrote: > > > On 8/16/24 7:44 AM, ira.weiny@xxxxxxxxx wrote: > > From: Navneet Singh <navneet.singh@xxxxxxxxx> > > > > CXL rev 3.1 section 8.2.9.2.1 adds the Dynamic Capacity Event Records. > > User space can use trace events for debugging of DC capacity changes. > > > > Add DC trace points to the trace log. > > > > Signed-off-by: Navneet Singh <navneet.singh@xxxxxxxxx> > > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx> > Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx> > > small nit below > > > > > --- > > Changes: > > [Alison: Update commit message] > > --- > > drivers/cxl/core/mbox.c | 4 +++ > > drivers/cxl/core/trace.h | 65 ++++++++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 69 insertions(+) > > > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > > index d43ac8eabf56..8202fc6c111d 100644 > > --- a/drivers/cxl/core/mbox.c > > +++ b/drivers/cxl/core/mbox.c > > @@ -977,6 +977,10 @@ static void __cxl_event_trace_record(const struct cxl_memdev *cxlmd, > > ev_type = CXL_CPER_EVENT_DRAM; > > else if (uuid_equal(uuid, &CXL_EVENT_MEM_MODULE_UUID)) > > ev_type = CXL_CPER_EVENT_MEM_MODULE; > > + else if (uuid_equal(uuid, &CXL_EVENT_DC_EVENT_UUID)) { > > + trace_cxl_dynamic_capacity(cxlmd, type, &record->event.dcd); > > + return; > > + } > > > > cxl_event_trace_record(cxlmd, type, ev_type, uuid, &record->event); > > } > > diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core/trace.h > > index 9167cfba7f59..a3a5269311ee 100644 > > --- a/drivers/cxl/core/trace.h > > +++ b/drivers/cxl/core/trace.h > > @@ -731,6 +731,71 @@ TRACE_EVENT(cxl_poison, > > ) > > ); > > > > +/* > > + * DYNAMIC CAPACITY Event Record - DER > > + * > > + * CXL rev 3.0 section 8.2.9.2.1.5 Table 8-47 > > Should we just use 3.1 since it's the latest? Yep done. Ira [snip]