Hi Babu,
On 8/20/24 9:19 AM, Moger, Babu wrote:
On 8/16/24 16:36, Reinette Chatre wrote:
On 8/6/24 3:00 PM, Babu Moger wrote:
Introduce resctrl_arch_event_config_get() and
resctrl_arch_event_config_set() to get/set architecture domain specific
mbm_total_cfg/mbm_local_cfg values. Also, remove unused config value
definitions.
hmmm ... while the config values are not used they are now established
ABI and any other architecture that wants to support configurable events
will need to follow these definitions. It is thus required to keep them
documented in the kernel in support of future changes. I
understand that they are documented in user docs, but could we keep them
in the kernel code also? Since they are unused they could perhaps be moved
to comments as a compromise?
How about just keeping them as is? I will just not remove it.
I am not aware of any policy here. I'm ok with keeping them as is. I do not
know if there are any static checkers that may complain, if there are then
the defines can be moved to comments.
Reinette
