Re: [PATCH v5 1/7] gpio: davinci: remove unnecessary printk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/08/2013 12:11 PM, Prabhakar Lad wrote:
From: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>

the devm_*() helper prints error messages in case of
errors no need to do the same in the driver.

Pls, drop it - devm_clk_get() doesn't always print error messages

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
---
  drivers/gpio/gpio-davinci.c |    6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 84be701..7230c43 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -389,11 +389,9 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
  	}

  	clk = devm_clk_get(dev, "gpio");
-	if (IS_ERR(clk)) {
-		printk(KERN_ERR "Error %ld getting gpio clock?\n",
-		       PTR_ERR(clk));
+	if (IS_ERR(clk))
  		return PTR_ERR(clk);
-	}
+
  	clk_prepare_enable(clk);

  	/*


--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux