On Wed, May 22, 2024, David Woodhouse wrote: > From: David Woodhouse <dwmw@xxxxxxxxxxxx> > > When the KVM clock is in master clock mode, updating the KVM clock is > pointless. Please explain why it's pointless. I almost feel bad asking you to elaborate since you've written wonderful changelogs for so many other patches, but far too many of the (historical) kvmclock commits assume the reader is some omniscient being, and it's definitely contributed to things getting into such a mess state. > Let the periodic work 'expire', and start it running again > from kvm_end_pvclock_update() if the master clock mode is ever turned > off again.