Hi Jon, On 2024/8/8 21:17, Jonathan Corbet wrote:
Guo Xuenan <guoxuenan@xxxxxxxxxx> writes:From: ganjie <ganjie5@xxxxxxxxxx> Commit 2b3d04787012 ("unicode: Add utf8-data module") changed the database file from 'utf8data.h' to 'utf8data.c' to build separate module, but it seems forgot to update Documentation/dontdiff. Remove 'utf8data.h' and add 'utf8data.c'. Signed-off-by: ganjie <ganjie5@xxxxxxxxxx> --- Documentation/dontdiff | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/dontdiff b/Documentation/dontdiff index 3c399f132e2d..94b3492dc301 100644 --- a/Documentation/dontdiff +++ b/Documentation/dontdiff @@ -262,7 +262,7 @@ vsyscall_32.lds wanxlfw.inc uImage unifdef -utf8data.h +utf8data.c wakeup.bin wakeup.elf wakeup.ldsI'll apply this, but does anybody actually use the dontdiff file anymore? I think it's old and, if being used, actively harmful; for example, it masks changes to "parse.c", an instance of which was added to git in January. Is there a reason to not just remove this file?
Completely agree，It seems fs/unicode module missing to update `dontdiff` I've actually never used it, seems that developers likely using .gitignore. eg. 98f2345773f（"unicode: fix .gitignore for generated utfdata file") Thanks Xuenan
Thanks, jon
-- Guo Xuenan [OS Kernel Lab] ----------------------------- Email: guoxuenan@xxxxxxxxxx
