On Sat, Aug 3, 2024 at 5:31 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: > > Tianyang! > > On Sat, Aug 03 2024 at 14:40, Tianyang Zhang wrote: > > > > We consider that since the original extioi-msi is still using the > > legacy-MSI interrupt model at irq-loongson-pch-msi.c, if per-device-MSI > > is directly supported in the AVEC support patch, it will result in the > > simultaneous use of two MSI-interrupt-mode in irq-loongson-pch-msi.c, > > which may seem a bit strange. So we decided to split it into two > > patches, the first one using tlegace-MSI to support AVEC interrupt > > controllers, and the second one will be uniformly modified to use > > per-device-MSI > > Adding new code with old functionality to convert it five minutes later > to the modern interface is just backwards. > > Convert the existing code over first and then add the new one, no? Yes, that looks better, thanks. Huacai > > Thanks, > > tglx > >