On Tue, Jul 30, 2024 at 11:00:38AM +0300, Leon Romanovsky wrote: > > + > > + void *inbuf __free(kvfree) = > > + kvzalloc(cmd->in_len, GFP_KERNEL | GFP_KERNEL_ACCOUNT); > > > <...> > > > + out_len = cmd->out_len; > > + void *outbuf __free(kvfree_errptr) = fwctl->ops->fw_rpc( > > + ucmd->uctx, cmd->scope, inbuf, cmd->in_len, &out_len); > > I was under impression that declaration of variables in C should be at the beginning > of block. Was it changed for the kernel? Yes, the compiler check blocking variables in the body was disabled to allow cleanup.h Jonathan said this is the agreed coding style to use for this Jason