On Mon, Jul 22, 2024 at 09:44:32AM -0500, Wei Huang wrote: > On 7/20/24 03:08, Lukas Wunner wrote: > > Paul Luse submitted a patch two years ago to save and restore > > TPH registers, perhaps you can include it in your patch set? > > Thanks for pointing them out. I skimmed through Paul's patch and it is > straightforward to integrate. > > Depending on Bjorn's preference, I can either integrate it into my > patchset with full credits to Paul and Jing, or Paul want to resubmit a > new version. The former would likely be better as I'm not sure Paul has the time to respin the patch. My recollection is that TPH save/restore support was dropped as a requirement for the Intel device this was originally developed for, but it would be a shame to lose the time and effort that already went into it and I think it might be useful for your use case as well to support reset recovery. > I read Bjorn's comments, lots of them have been addressed in my patchset > (e.g. move under /pci/pcie, support _DSM and dev->tph). Indeed, good job! Thanks for taking a look! Lukas