Re: [PATCH v2 07/10] riscv: Improve amoswap.X use in xchg()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Alexandre Ghiti <alex@xxxxxxxx>
Subject: Re: [PATCH v2 07/10] riscv: Improve amoswap.X use in xchg()
From: Andrea Parri <parri.andrea@xxxxxxxxx>
Date: Wed, 10 Jul 2024 02:09:02 +0200
Cc: Alexandre Ghiti <alexghiti@xxxxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, Palmer Dabbelt <palmer@xxxxxxxxxxx>, Albert Ou <aou@xxxxxxxxxxxxxxxxx>, Nathan Chancellor <nathan@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Waiman Long <longman@xxxxxxxxxx>, Boqun Feng <boqun.feng@xxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Leonardo Bras <leobras@xxxxxxxxxx>, Guo Ren <guoren@xxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, Andrea Parri <andrea@xxxxxxxxxxxx>
In-reply-to: <c6c305a7-37d0-4834-ac65-1ac5d32014d1@ghiti.fr>
References: <20240626130347.520750-1-alexghiti@rivosinc.com> <20240626130347.520750-8-alexghiti@rivosinc.com> <Zn1wDAXjBdJu48Oi@andrea> <c6c305a7-37d0-4834-ac65-1ac5d32014d1@ghiti.fr>

> > I actually see no reason for this patch, please see also my remarks
> > /question on patch #4.
> 
> You mean that we can't improve the fully-ordered version here?

Well, I mean, this patch doesn't AFAICT.  You've recently fixed these
LR/SC mappings in 1d84afaf0252 ("riscv: Fix fully ordered LR/SC
xchg[8|16]() implementations"), and the remaining look just fine to me.

  Andrea

References:
- [PATCH v2 00/10] Zacas/Zabha support and qspinlocks
  - From: Alexandre Ghiti
- [PATCH v2 07/10] riscv: Improve amoswap.X use in xchg()
  - From: Alexandre Ghiti
- Re: [PATCH v2 07/10] riscv: Improve amoswap.X use in xchg()
  - From: Andrea Parri
- Re: [PATCH v2 07/10] riscv: Improve amoswap.X use in xchg()
  - From: Alexandre Ghiti

Prev by Date: Re: [PATCH v2 03/10] riscv: Implement cmpxchg8/16() using Zabha
Next by Date: [PATCH net-next v16 00/13] Device Memory TCP
Previous by thread: Re: [PATCH v2 07/10] riscv: Improve amoswap.X use in xchg()
Next by thread: [PATCH v2 08/10] asm-generic: ticket-lock: Reuse arch_spinlock_t of qspinlock
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]