On Wed, Jun 26, 2024 at 09:57:32AM -0500, David Lechner wrote: > On 6/25/24 4:53 PM, Marcelo Schmitt wrote: > > +#define SPI_CONTROLLER_MOSI_IDLE_LOW BIT(8) /* Can idle MOSI low */ > > +#define SPI_CONTROLLER_MOSI_IDLE_HIGH BIT(9) /* Can idle MOSI high */ > These two flags above are still not used anywhere and are redundant with > the SPI_MOSI_IDLE_LOW/HIGH flags below so I don't think we should be adding > these. Yes. > Also, what is the plan for adding these flags to other SPI controllers. For > example, the IMX controller in [1] sounds like it should also support > SPI_MOSI_IDLE_HIGH. And your comments on an earlier version of this series > made it sound like Raspberry Pi is always SPI_MOSI_IDLE_LOW, so should > have that flag. I don't think we need a specific plan there, obviously it'd be nice for people to go through and enable but it's also fine to just leave this for someone who needs the support to implement.
Attachment:
signature.asc
Description: PGP signature
