> -----Original Message----- > From: Andrew Lunn <andrew@xxxxxxx> > Sent: Monday, 24 June 2024 22:57 > To: Danielle Ratson <danieller@xxxxxxxxxx> > Cc: netdev@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; > kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; corbet@xxxxxxx; > linux@xxxxxxxxxxxxxxx; sdf@xxxxxxxxxx; kory.maincent@xxxxxxxxxxx; > maxime.chevallier@xxxxxxxxxxx; vladimir.oltean@xxxxxxx; > przemyslaw.kitszel@xxxxxxxxx; ahmed.zaki@xxxxxxxxx; > richardcochran@xxxxxxxxx; shayagr@xxxxxxxxxx; > paul.greenwalt@xxxxxxxxx; jiri@xxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; mlxsw <mlxsw@xxxxxxxxxx>; Ido Schimmel > <idosch@xxxxxxxxxx>; Petr Machata <petrm@xxxxxxxxxx> > Subject: Re: [PATCH net-next v7 8/9] ethtool: cmis_fw_update: add a layer for > supporting firmware update using CDB > > > +static int cmis_fw_update_reset(struct net_device *dev) { > > + __u32 reset_data = ETH_RESET_PHY; > > + > > + return dev->ethtool_ops->reset(dev, &reset_data); > > Is there a test somewhere that this op is actually implemented? > > Maybe the next patch. Yes, indeed. > > Andrew