On Tue, Jun 18, 2024 at 04:59:22PM GMT, Ard Biesheuvel wrote:
> On Tue, 18 Jun 2024 at 16:40, Maxwell Bland <mbland@xxxxxxxxxxxx> wrote:
> > @@ -105,11 +106,6 @@ static const struct prot_bits pte_bits[] = {
> > .val = PTE_CONT,
> > .set = "CON",
> > .clear = " ",
> > - }, {
> > - .mask = PTE_TABLE_BIT,
> > - .val = PTE_TABLE_BIT,
> > - .set = " ",
> > - .clear = "BLK",
> > }, {
> > .mask = PTE_UXN,
> > .val = PTE_UXN,
> This table will need to distinguish between table and block entries.
>
> I suspect that the distinction pte_bits <-> pxd_bits is not so useful
> here. It would be better to have tbl_bits[], with pointers to it in
> the pg_level array, where the PTE level one is set to NULL.
Nice, thanks! Adding now. I'll slate a v5 release for next monday.
Maxwell
