Re: [PATCH v2 1/2] scripts: fix most issues reported by pylint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,Dongliang

在 2024/6/17 09:05, Dongliang Mu 写道:

On 2024/6/16 03:42, Jonathan Corbet wrote:
Dongliang Mu <dzm91@xxxxxxxxxxx> writes:

Pylint reports many coding style issues of scripts/checktransupdate.py

This patch fixes most issues with the following contents:
- add or revise comments for all functions
- use format string suggested by python

Signed-off-by: Dongliang Mu <dzm91@xxxxxxxxxxx>
---
  scripts/checktransupdate.py | 55 ++++++++++++++++---------------------
  1 file changed, 24 insertions(+), 31 deletions(-)
How does this differ from v1?  Please always give that information so
reviewers know what's going on.

Hi Jon,

Patch 1/2 in v2 patch has no difference with Patch 1/2 in v1. Randy put up some change requests about

the help documentation, and it is written in the Patch 2/2 in v2.

I am not sure how to show this information in Patch 1/2. How about "v1->v2: no changes"?


Let's make a cover letter, just like:

<https://lore.kernel.org/netdev/cover.1716973237.git.siyanteng@xxxxxxxxxxx/>


you can run:


$: git format-patch xxxxx   --cover-letter


BTW,

It seem that you forget to cc  linux-doc@xxxxxxxxxxxxxxx.


Thanks,

Yanteng





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux