On Fri, 2024-06-07 at 16:14 +0300, Ilpo Järvinen wrote: > On Wed, 5 Jun 2024, David E. Box wrote: > > > Intel On Demand adds attestation and firmware measurement retrieval > > services through use of the protocols defined the Security Protocols and > > Data Measurement (SPDM) specification. SPDM messages exchanges are used to > > authenticate On Demand hardware and to retrieve signed measurements of the > > NVRAM state used to track feature provisioning and the NVRAM state used for > > metering services. These allow software to verify the authenticity of the > > On Demand hardware as well as the integrity of the reported silicon > > configuration. > > > > Add an ioctl interface for sending SPDM messages through the On Demand > > mailbox. Provides commands to get a list of SPDM enabled devices, get the > > message size limits for SPDM Requesters and Responders, and perform an SPDM > > message exchange. > > > > Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx> > > Link: > > https://www.dmtf.org/sites/default/files/standards/documents/DSP0274_1.0.1.pdf > > [1] > > --- > > > +static int sdsi_spdm_do_command(struct sdsi_priv *priv, > > + struct sdsi_spdm_command __user *argp) > > +{ > > + u32 req_size, rsp_size; > > + > > + if (get_user(req_size, &argp->size)) > > + return -EFAULT; > > + > > + if (req_size < 4 || req_size > sizeof(struct sdsi_spdm_message)) > > Hi David, > > Is that 4 actually SPDM_HEADER_SIZE? > > If my guess is correct, no need to send an updated version, I'll just fix > it while applying. It is SPDM_HEADER_SIZE but I already fixed it in V4 since I had to address an LKP report. David > >
