On 6/6/24 6:34 AM, Jonathan Cameron wrote: > On Wed, 5 Jun 2024 15:27:26 -0300 > Jason Gunthorpe <jgg@xxxxxxxxxx> wrote: > >> On Wed, Jun 05, 2024 at 12:07:37PM +0100, Jonathan Cameron wrote: >> >>>> I don't recall that dramatic conclusion in the discussion, but it does >>>> make alot of sense to me. >>> >>> I'll be less lazy (and today found the search foo to track it down). >>> >>> https://lore.kernel.org/all/CAHk-=wicfvWPuRVDG5R1mZSxD8Xg=-0nLOiHay2T_UJ0yDX42g@xxxxxxxxxxxxxx/ >> >> Oh that is a bit different discussion than I was thinking of.. I fixed >> all the cases to follow this advise and checked that all the free >> functions are proper pairs of whatever is being allocated. > > Yes. I think we are approaching the point where maybe we need > a 'best practice guide' somewhere. It is sort of coding style, but > it is perhaps rather complex perhaps to put in that doc. > > I'm happy to help review such changes, but it would be too far down > my todo list if I took on writing one. > > Maybe there is one I've missed? There is not a published one that I know of, other than one that I pasted into an email in Dec-2023, in this post: https://lore.kernel.org/lkml/34e27c57-fc18-4918-bf44-4f8a53825361@xxxxxxxxxxxxx/ -- #Randy https://people.kernel.org/tglx/notes-about-netiquette https://subspace.kernel.org/etiquette.html